Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Cascade OnDelete for ownerships without conventions to avoid false model diffs. #18563

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Set Cascade OnDelete for ownerships without conventions to avoid false model diffs. #18563

merged 2 commits into from
Oct 24, 2019

Conversation

AndriySvyryd
Copy link
Member

Fixes #18045

@AndriySvyryd AndriySvyryd changed the base branch from release/3.1 to release/3.1-preview2 October 24, 2019 06:44
@AndriySvyryd AndriySvyryd changed the base branch from release/3.1-preview2 to release/3.1 October 24, 2019 18:13
smitpatel
smitpatel reviewed Oct 24, 2019
View reviewed changes
src/EFCore/Metadata/Internal/InternalRelationshipBuilder.cs
@@ -1045,6 +1045,12 @@ public virtual InternalRelationshipBuilder IsOwnership(bool? ownership, Configur
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 1027, They can be only 0 or 1 otherownerships.

@AndriySvyryd AndriySvyryd merged commit 680b887 into release/3.1 Oct 24, 2019
@AndriySvyryd AndriySvyryd deleted the Issue18045 branch October 24, 2019 23:38
@ajcvickers ajcvickers mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@bricelam bricelam Awaiting requested review from bricelam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Foreign keys of owned types are regenerated in migrations
2 participants
@AndriySvyryd @smitpatel